statistic: fix panic when building topN (#47928)#47989
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from Oct 31, 2023
Merged
statistic: fix panic when building topN (#47928)#47989ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
0xPoe
approved these changes
Oct 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47989 +/- ##
================================================
Coverage ? 73.7357%
================================================
Files ? 1085
Lines ? 349414
Branches ? 0
================================================
Hits ? 257643
Misses ? 75311
Partials ? 16460 |
hawkingrei
approved these changes
Oct 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #47928
Signed-off-by: hi-rustin rustin.liu@gmail.com
What problem does this PR solve?
Issue Number: close #35948
Problem Summary:
What is changed and how it works?
The issue arises when a value appears twice in the topN list, triggering a panic. The solution involves breaking out of the loop as soon as we find the duplicate value. This bug seems to occur only when the column is of JSON type. Since we haven't been able to reproduce the issue, we've added a warning log to print all topN values, helping us identify the duplicated value.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.