Skip to content

lightning: every HTTP retry should use its own request (#47959)#47970

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-5.3from
ti-chi-bot:cherry-pick-47959-to-release-5.3
Closed

lightning: every HTTP retry should use its own request (#47959)#47970
ti-chi-bot wants to merge 1 commit intopingcap:release-5.3from
ti-chi-bot:cherry-pick-47959-to-release-5.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 25, 2023

This is an automated cherry-pick of #47959

What problem does this PR solve?

Issue Number: close #47930

Problem Summary:

What is changed and how it works?

http.Client.Do will read the body of request, so the request should not be reused.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#47959
af8b581 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Oct 25, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 25, 2023
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign windtalker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot closed this Dec 1, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 1, 2023

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

@ti-chi-bot ti-chi-bot deleted the cherry-pick-47959-to-release-5.3 branch April 15, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lance6716 lance6716

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @lance6716