types: more strict for types.StrictFlags#47842
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom Oct 20, 2023
Merged
types: more strict for types.StrictFlags#47842ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
types.StrictFlags#47842ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Conversation
c28e150 to
ca5614f
Compare
0d4acf2 to
6f53dda
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47842 +/- ##
================================================
+ Coverage 71.8756% 72.8088% +0.9331%
================================================
Files 1399 1422 +23
Lines 405325 411696 +6371
================================================
+ Hits 291330 299751 +8421
+ Misses 94353 93101 -1252
+ Partials 19642 18844 -798
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6f53dda to
aee6392
Compare
a2a912d to
67cd6f0
Compare
67cd6f0 to
ae0c3af
Compare
lance6716
approved these changes
Oct 20, 2023
YangKeao
approved these changes
Oct 20, 2023
| // DefaultStmtFlags is the default flags for statement context with the flag `FlagAllowNegativeToUnsigned` set. | ||
| // TODO: make DefaultStmtFlags to be equal with StrictFlags, and setting flag `FlagAllowNegativeToUnsigned` | ||
| // is only for make the code to be equivalent with the old implement during refactoring. | ||
| const DefaultStmtFlags = context.DefaultStmtFlags |
Member
There was a problem hiding this comment.
Good! I'll also need to introduce the Default flags in #47029 🤣
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, windtalker, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #47829
What is changed and how it works?
FlagClipNegativeToZerowithFlagAllowNegativeToUnsignedwhich has a opposite semantics to make theStrictFlags(all-zero value) more strict.DefaultStmtFlagswithFlagAllowNegativeToUnsignedset to 1 to keep it same behavior with old implement.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.