Skip to content

*: handle region error for GetMvccByEncodedKey API (#47811)#47820

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-47811-to-release-7.5
Nov 10, 2023
Merged

*: handle region error for GetMvccByEncodedKey API (#47811)#47820
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-47811-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 20, 2023

This is an automated cherry-pick of #47811

What problem does this PR solve?

Issue Number: close #47807

Problem Summary:

What is changed and how it works?

Before:

Related TIDB Log:

# rg "failed to get schema version"
tidb.log
9758:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
9760:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
9762:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
9764:[2023/10/19 18:11:18.100 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]
10034:[2023/10/19 18:11:28.173 +08:00] [WARN] [domain.go:195] ["failed to get schema version"] [error="There is no Write MVCC info for the schema version"] [version=40]

img_v2_0f786210-a576-47d7-97e8-17d78c88324g

This PR:

# rg "failed to get schema version"
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520 @ti-chi-bot
init
72f7021 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
fix test
2cb271d 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
make bazel_prepare
4e72cb3 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refine test
9342468 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
address comment
d98af91 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-23 05:59:25.885972929 +0000 UTC m=+2241563.473083074: ☑️ agreed by crazycs520.
  • 2023-11-07 08:50:19.845821503 +0000 UTC m=+3547817.432931647: ☑️ agreed by MyonKeminta.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 7, 2023
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 7, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, MyonKeminta, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,crazycs520,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 76fab0e into pingcap:release-7.5 Nov 10, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-47811-to-release-7.5 branch April 15, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zyguan zyguan zyguan approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@you06 you06 Awaiting requested review from you06

@ekexium ekexium Awaiting requested review from ekexium

Assignees

@crazycs520 crazycs520

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @cfzjywxk @zyguan @MyonKeminta @crazycs520