Skip to content

tests: fix unstable test in planner/core/integration_partition#47446

Closed
Defined2014 wants to merge 1 commit intopingcap:masterfrom
Defined2014:fix-unstable-test
Closed

tests: fix unstable test in planner/core/integration_partition#47446
Defined2014 wants to merge 1 commit intopingcap:masterfrom
Defined2014:fix-unstable-test

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Oct 8, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2023
@Defined2014 Defined2014 added skip-issue-check Indicates that a PR no need to check linked issue. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Oct 8, 2023
@tiprow
Copy link

tiprow bot commented Oct 8, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2023
@Defined2014 Defined2014 requested a review from YangKeao October 8, 2023 07:01
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@tangenta tangenta mentioned this pull request Oct 8, 2023
Merged
13 tasks
YangKeao
YangKeao approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also fixed it in #47443 🤦

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-08 07:01:55.124363321 +0000 UTC m=+949312.711473460: ☑️ agreed by tangenta.
  • 2023-10-08 07:03:42.377400816 +0000 UTC m=+949419.964510961: ☑️ agreed by YangKeao.

@Defined2014
Copy link
Contributor Author

Defined2014 commented Oct 8, 2023 •
edited
Loading

LGTM. I also fixed it in #47443 🤦

Ok, I will close this avoid merge confilct.

@Defined2014 Defined2014 closed this Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Defined2014 Defined2014 deleted the fix-unstable-test branch November 20, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@YangKeao YangKeao YangKeao approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Defined2014 @hawkingrei @YangKeao @tangenta