Skip to content

ddl: fix duplicate inforSchema information of rename tables (#47087)#47141

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-47087-to-release-6.5
Nov 22, 2023
Merged

ddl: fix duplicate inforSchema information of rename tables (#47087)#47141
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-47087-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 20, 2023

This is an automated cherry-pick of #47087

What problem does this PR solve?

Issue Number: close #47064

Problem Summary:

What is changed and how it works?

it seems lead to ApplyDiff twice for the first table of rename table list.

https://github.com/pingcap/tidb/blob/4bd39b5fd712f06b1c4594418a88ee1740f6f1aa/ddl/ddl_worker.go#L1381C2-L1381C2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 20, 2023
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label Sep 20, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@71bcc44). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #47141   +/-   ##
================================================
  Coverage               ?   74.5416%           
================================================
  Files                  ?       1085           
  Lines                  ?     356083           
  Branches               ?          0           
================================================
  Hits                   ?     265430           
  Misses                 ?      74468           
  Partials               ?      16185

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 21, 2023
Benjamin2037
Benjamin2037 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2023
Benjamin2037
Benjamin2037 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2023

@Benjamin2037: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD
GMHDBJD approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-22 03:53:54.430165296 +0000 UTC m=+376463.095391508: ☑️ agreed by Benjamin2037.
  • 2023-11-22 08:05:11.417584008 +0000 UTC m=+391540.082810202: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit 6badab9 into pingcap:release-6.5 Nov 22, 2023
@Benjamin2037 Benjamin2037 mentioned this pull request Nov 30, 2023
Merged
16 tasks
@ti-chi-bot ti-chi-bot deleted the cherry-pick-47087-to-release-6.5 branch April 15, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @Benjamin2037 @GMHDBJD @jiyfhust