Skip to content

planner: fix group_concat function couldn't resolve the index of its order-by item (#46419)#47120

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-46419-to-release-6.5
Oct 30, 2023
Merged

planner: fix group_concat function couldn't resolve the index of its order-by item (#46419)#47120
ti-chi-bot[bot] merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-46419-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 20, 2023

This is an automated cherry-pick of #46419

What problem does this PR solve?

Issue Number: close #41986

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix group_concat function couldn't resolve the index of its order-by item

@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#46419
c142bac 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 30, 2023
@AilinKid
.
5c9cb88 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
bcf750b 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 30, 2023
@AilinKid
Copy link
Contributor

AilinKid commented Oct 30, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Oct 30, 2023

@AilinKid: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 07:57:19.416251289 +0000 UTC m=+2853437.003361428: ☑️ agreed by AilinKid.
  • 2023-10-30 09:59:41.471381494 +0000 UTC m=+2860779.058491639: ☑️ agreed by qw4990.

@codecov
Copy link

codecov bot commented Oct 30, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@ti-chi-bot ti-chi-bot bot merged commit 62766de into pingcap:release-6.5 Oct 30, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-46419-to-release-6.5 branch April 15, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees

@AilinKid AilinKid

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @AilinKid @qw4990