variable: always truncate tidb_session_alias when it is not a valid value#46707
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Sep 12, 2023
Merged
Conversation
tidb_session_alias when it is not a valid…tidb_session_alias when it is not a valid value
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46707 +/- ##
================================================
+ Coverage 73.3586% 74.2225% +0.8638%
================================================
Files 1315 1350 +35
Lines 395675 415634 +19959
================================================
+ Hits 290262 308494 +18232
- Misses 86932 88712 +1780
+ Partials 18481 18428 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
8 tasks
CbcWestwolf
approved these changes
Sep 7, 2023
Collaborator
Author
|
/retest |
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, CbcWestwolf, easonn7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #46071
What is changed and how it works?
after discussing, we need always truncate value when setting
tidb_session_aliaseven if the value is not valid.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.