*: Exchange partition, fix LIST COLUMNs validation as well as NULL validation (#46533)#46698
Conversation
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiancaiamao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
…6533-to-release-6.5
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46698 +/- ##
================================================
Coverage ? 73.6820%
================================================
Files ? 1084
Lines ? 348321
Branches ? 0
================================================
Hits ? 256650
Misses ? 75207
Partials ? 16464 |
|
/merge |
|
@bb7133: We have migrated to builtin Please use
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #46533
What problem does this PR solve?
Issue Number: close #46492
Problem Summary:
The main issue was that the values are store in single quoted strings, and when adding them to the parser as parameters, they are quoted again, which issues (ignored) internal warnings, and no matching rows will be found.
Also the check did not handle NULL, so I added proper null-safe comparison.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.