Skip to content

autoid_service: fix potential 'duplicated entry' error when tidb exit for AUTO_ID_CACHE=1 tables #46445#46541

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5-20230830-v6.5.3from
tiancaiamao:hotfix-6.5.3
Aug 31, 2023
Merged

autoid_service: fix potential 'duplicated entry' error when tidb exit for AUTO_ID_CACHE=1 tables #46445#46541
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5-20230830-v6.5.3from
tiancaiamao:hotfix-6.5.3

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Aug 31, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #46444

Problem Summary:

Hotfix for v6.5.3, cherry-pick #46445 and #46526

What is changed and how it works?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2023
@tiprow
Copy link

tiprow bot commented Aug 31, 2023

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 31, 2023
bb7133
bb7133 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-31 03:06:53.76606659 +0000 UTC m=+1982778.315082562: ☑️ agreed by YangKeao.
  • 2023-08-31 03:14:48.320981168 +0000 UTC m=+1983252.869997153: ☑️ agreed by bb7133.

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Aug 31, 2023

/retest-required

@tiprow
Copy link

tiprow bot commented Aug 31, 2023

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Aug 31, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 31, 2023

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230830-v6.5.3@71e6696). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-6.5-20230830-v6.5.3     #46541   +/-   ##
================================================================
  Coverage                               ?   73.4111%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346420           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254311           
  Misses                                 ?      75689           
  Partials                               ?      16420

@ti-chi-bot ti-chi-bot bot merged commit d48d236 into pingcap:release-6.5-20230830-v6.5.3 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiancaiamao @bb7133 @YangKeao