Skip to content

planner: fix wrong result when pushing Agg down through Union in MPP plans (#46310)#46517

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-46310-to-release-7.1
Oct 13, 2023
Merged

planner: fix wrong result when pushing Agg down through Union in MPP plans (#46310)#46517
ti-chi-bot[bot] merged 5 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-46310-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 30, 2023

This is an automated cherry-pick of #46310

What problem does this PR solve?

Issue Number: close #45850

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix wrong result when pushing Agg down through Union in MPP plans

@AilinKid @ti-chi-bot
This is an automated cherry-pick of pingcap#46310
2358fa4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Aug 30, 2023
@ti-chi-bot ti-chi-bot added sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 30, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
fixdb
fixdb reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the conflict?

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 25, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 12, 2023
AilinKid and others added 2 commits October 12, 2023 18:30
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2023
@AilinKid
.
9397a40 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-12 08:51:37.324389019 +0000 UTC m=+1301494.911499165: ☑️ agreed by chrysan.
  • 2023-10-12 11:01:10.682574821 +0000 UTC m=+1309268.269684951: ☑️ agreed by qw4990.

@chrysan
Copy link
Contributor

chrysan commented Oct 12, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Oct 12, 2023

@chrysan: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
.
e8646bf 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
Copy link
Contributor

AilinKid commented Oct 13, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Oct 13, 2023

@AilinKid: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@4cb399e). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.1     #46517   +/-   ##
================================================
  Coverage               ?   73.4400%           
================================================
  Files                  ?       1205           
  Lines                  ?     377361           
  Branches               ?          0           
================================================
  Hits                   ?     277134           
  Misses                 ?      82563           
  Partials               ?      17664

@ti-chi-bot ti-chi-bot bot merged commit e07cf40 into pingcap:release-7.1 Oct 13, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-46310-to-release-7.1 branch April 15, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fixdb fixdb fixdb left review comments

@qw4990 qw4990 qw4990 approved these changes

+1 more reviewer

@chrysan chrysan chrysan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AilinKid AilinKid

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @chrysan @AilinKid @fixdb @qw4990