Skip to content

autoid_service: fix potential 'duplicated entry' error when tidb exit for AUTO_ID_CACHE=1 tables (#46445)#46501

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-46445-to-release-6.5
Nov 27, 2023
Merged

autoid_service: fix potential 'duplicated entry' error when tidb exit for AUTO_ID_CACHE=1 tables (#46445)#46501
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-46445-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 30, 2023

This is an automated cherry-pick of #46445

What problem does this PR solve?

Issue Number: close #46444

Problem Summary:

What is changed and how it works?

If the autoid service node is not leader, it should not save the cached id back to tikv.

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix potential 'duplicated entry' error when tidb exit for AUTO_ID_CACHE=1 tables.
The bug could happen when a tidb is the autoid_service leader previously, and exit as non-leader, it stores staled next autoid value to tikv in a force rebase way. If the value is loaded again, the autoid decreases and could cause duplicates.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 30, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@d7ce2f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46501   +/-   ##
================================================
  Coverage               ?   75.1966%           
================================================
  Files                  ?       1087           
  Lines                  ?     361681           
  Branches               ?          0           
================================================
  Hits                   ?     271972           
  Misses                 ?      73523           
  Partials               ?      16186

YangKeao
YangKeao approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 30, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-30 08:34:30.168593065 +0000 UTC m=+1916034.717609052: ☑️ agreed by YangKeao.
  • 2023-11-27 01:51:14.130288924 +0000 UTC m=+801102.795515119: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot merged commit a2aeb3b into pingcap:release-6.5 Nov 27, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-46445-to-release-6.5 branch April 15, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YangKeao YangKeao YangKeao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees

@tiancaiamao tiancaiamao

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @YangKeao @djshow832 @tiancaiamao