Skip to content

planner: cherry-pick #45824, #45831 and #46312 | tidb-test=pr/2207#46391

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.1-20230824-v7.1.1from
Defined2014:cp-for-7.1
Aug 25, 2023
Merged

planner: cherry-pick #45824, #45831 and #46312 | tidb-test=pr/2207#46391
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.1-20230824-v7.1.1from
Defined2014:cp-for-7.1

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Aug 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45758 , close #45805, close #45804, close #46311

Problem Summary: cherry pick #45831, #45824 and #46312 for hot-fix branch

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2023
@tiprow
Copy link

tiprow bot commented Aug 24, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title planner: cherry-pick #45824 and #45831 planner: cherry-pick #45824 and #45831 | tidb-test=pr/2207 Aug 24, 2023
@Defined2014
Copy link
Contributor Author

Defined2014 commented Aug 24, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Aug 24, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

Defined2014 commented Aug 24, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Aug 24, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1-20230824-v7.1.1@cf44157). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-7.1-20230824-v7.1.1     #46391   +/-   ##
================================================================
  Coverage                               ?   73.4269%           
================================================================
  Files                                  ?       1202           
  Lines                                  ?     376242           
  Branches                               ?          0           
================================================================
  Hits                                   ?     276263           
  Misses                                 ?      82326           
  Partials                               ?      17653

@Defined2014 Defined2014 requested a review from jackysp August 24, 2023 08:14
@Defined2014 Defined2014 changed the title planner: cherry-pick #45824 and #45831 | tidb-test=pr/2207 planner: cherry-pick #45824, #45831 and #46312 | tidb-test=pr/2207 Aug 24, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 24, 2023
@Defined2014 Defined2014 requested a review from AilinKid August 25, 2023 02:46
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 10:31:05.000752426 +0000 UTC m=+1404629.549768417: ☑️ agreed by time-and-fate.
  • 2023-08-25 02:56:53.52022532 +0000 UTC m=+1463778.069241306: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 81ceb31 into pingcap:release-7.1-20230824-v7.1.1 Aug 25, 2023
@yilongrong
Copy link

yilongrong commented Sep 11, 2023

Please help to merge into v7.1.2 , Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@jackysp jackysp Awaiting requested review from jackysp

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Defined2014 @yilongrong @qw4990 @time-and-fate @winoros @jackysp