Skip to content

binlog: fix the wrong fatal error when binlog is too large (#46365)#46378

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-46365-to-release-6.1
Closed

binlog: fix the wrong fatal error when binlog is too large (#46365)#46378
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-46365-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 24, 2023 •
edited by jackysp
Loading

This is an automated cherry-pick of #46365

What problem does this PR solve?

Issue Number: close #28659

Problem Summary:

What is changed and how it works?

Catch both send and receive large binlog error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Create a cluster with binlog
  2. Commit a very large delete statement over 2G.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp @ti-chi-bot
binlog: fix the wrong fatal error when binlog is too large
6b8cfc2 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 24, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 24, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 24, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 24, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Mar 4, 2025
Benjamin2037
Benjamin2037 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, jackysp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 21, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 06:21:32.519703475 +0000 UTC m=+1389657.068719462: ☑️ agreed by jackysp.
  • 2025-04-21 07:11:50.396913094 +0000 UTC m=+253254.208703460: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot closed this Jun 13, 2025
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 13, 2025

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackysp jackysp jackysp approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@jackysp jackysp

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @jackysp @Benjamin2037