*: fix the duplicate entry error when using BR to restore a NONCLUSTERED AUTO_ID_CACHE=1 table (#46127)#46217
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from Aug 18, 2023
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Contributor
|
/retest-required |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46217 +/- ##
================================================
Coverage ? 73.6729%
================================================
Files ? 1084
Lines ? 347923
Branches ? 0
================================================
Hits ? 256325
Misses ? 75143
Partials ? 16455 |
kennytm
approved these changes
Aug 18, 2023
3pointer
approved these changes
Aug 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, kennytm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #46127
What problem does this PR solve?
Issue Number: close #46093
Problem Summary:
What is changed and how it works?
For a NONCLUSTERED table with AUTO_ID_CACHE=1, like the case in #46093,
there are both
auto_increment_idand_tidb_rowid.The
model.TableInfoonly get one fieldAutoIncID, the information is not enough to recover the table correctly.So a
AutoIncIDExtrafield is added for that case. We can record_tidb_rowidinAutoIncIDExtraand recover the_tidb_rowidfrom it.Check List
Tests
Test the case follow the steps in #46093 manually.
I'm trying to add some test but find it difficult to do that in a unit test.
For example, I tried to add it in the
tests/realtikvtest/brietestbut found that it does not start the server layer so the auto id service does not run and I can't test the AUTO_ID_CACHE=1I tried to add it in the
server/testswhere a server is started, but it use unistore andbr recover table ...can not run with unistore.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.