Skip to content

*: add MVCC version ratio to slow log metrics (#44897)#46205

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-44897-to-release-6.5
Aug 18, 2023
Merged

*: add MVCC version ratio to slow log metrics (#44897)#46205
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-44897-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 18, 2023

This is an automated cherry-pick of #44897

What problem does this PR solve?

Issue Number: close #44896

Problem Summary:
Add MVCC version ratio to slow log metrics.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. create a new cluster
  2. run the benchmark test: sysbench oltp_read_write
  3. check slow query panel on grafana
image
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp @ti-chi-bot
This is an automated cherry-pick of pingcap#44897
ea7c8dd 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added component/metrics release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 18, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@jackysp
resolve conflicts
7bdaf05 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 18, 2023
@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

/run-monitor-test

@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

image Because there was a conflict, I manually tested it. It seems to be okay.

@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

/run-monitor-test

@qiffang it doesn't work anymore, PTAL.

@jackysp jackysp requested review from bb7133 and cfzjywxk August 18, 2023 01:37
@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

/rebuild

@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

@hawkingrei why is the building failed, could you please take a look? Thx!

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 18, 2023
@hawkingrei
Copy link
Member

hawkingrei commented Aug 18, 2023

/retest

bb7133
bb7133 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 18, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 03:21:06.970565931 +0000 UTC m=+860431.519581914: ☑️ agreed by bb7133.
  • 2023-08-18 03:21:41.580030409 +0000 UTC m=+860466.129046395: ☑️ agreed by jackysp.

@hawkingrei
Copy link
Member

hawkingrei commented Aug 18, 2023

@hawkingrei why is the building failed, could you please take a look? Thx!

It is a CI timeout. the solution is to rerun it.

@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@76953b2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46205   +/-   ##
================================================
  Coverage               ?   73.7503%           
================================================
  Files                  ?       1084           
  Lines                  ?     348409           
  Branches               ?          0           
================================================
  Hits                   ?     256953           
  Misses                 ?      75015           
  Partials               ?      16441

@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

@jackysp: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jackysp
Copy link
Contributor

jackysp commented Aug 18, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, jackysp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b1eebca into pingcap:release-6.5 Aug 18, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-44897-to-release-6.5 branch April 15, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@jackysp jackysp jackysp approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees

@jackysp jackysp

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. component/metrics lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @jackysp @hawkingrei @bb7133