ddl, session: using table ID instead of partition ID when calling SplitRegions (#46156)#46163
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from Aug 17, 2023
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
crazycs520
approved these changes
Aug 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46163 +/- ##
================================================
Coverage ? 73.6545%
================================================
Files ? 1083
Lines ? 347730
Branches ? 0
================================================
Hits ? 256119
Misses ? 75165
Partials ? 16446 |
tangenta
approved these changes
Aug 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #46156
What problem does this PR solve?
Issue Number: close #46135
Problem Summary:
tidb/ddl/split_region.go
Lines 44 to 46 in 95b4dcc
tidb/ddl/split_region.go
Lines 121 to 123 in 95b4dcc
https://github.com/tikv/pd/blob/346e7716e2598dfba2db6afa73c3731e15449f49/client/client.go#L1403-L1409
As you can see from the above code, the tableID passed to
SplitRegionsis the ID of the partitioned table. And we use tableID asGrouppass to PD. So different partition ID uses different group ID in a table which makes the split region is uneven.What is changed and how it works?
In the partition table, we use table ID as a group ID to pass PD.
Check List
Tests
Before this PR:

After this PR:

Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.