Skip to content

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant#46147

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.1from
yibin87:release-6.1
Aug 16, 2023
Merged

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant#46147
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.1from
yibin87:release-6.1

Conversation

@yibin87
Copy link
Contributor

@yibin87 yibin87 commented Aug 16, 2023

This is an automated cherry-pick of #45945

What problem does this PR solve?

Issue Number: close #38361

Problem Summary: When compare datetime/timestamp column with numeric constant, try convert numeric constant to timestamp datetime, do nothing if conversion failed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@yibin87
Manually cherry pick
8d08791 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 16, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Aug 16, 2023
@tiprow
Copy link

tiprow bot commented Aug 16, 2023

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Fix ut error
a200bba 
Signed-off-by: yibin <huyibin@pingcap.com>
windtalker
windtalker approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 08:08:26.312329188 +0000 UTC m=+704870.861345174: ☑️ agreed by windtalker.
  • 2023-08-16 08:08:40.215846697 +0000 UTC m=+704884.764862684: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit fda7d77 into pingcap:release-6.1 Aug 16, 2023
@windtalker windtalker mentioned this pull request Aug 16, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yibin87 @windtalker @hawkingrei @ti-chi-bot