br: configure the httpclient for external storage (#46040)#46140
Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-6.5from Aug 17, 2023
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
11 tasks
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Leavrth
approved these changes
Aug 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46140 +/- ##
================================================
Coverage ? 73.6577%
================================================
Files ? 1083
Lines ? 347784
Branches ? 0
================================================
Hits ? 256170
Misses ? 75163
Partials ? 16451 |
3pointer
approved these changes
Aug 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #46040
What problem does this PR solve?
Issue Number: close #46011
Problem Summary:
br use the default http client to connect the external storage, which doesn't have enough reuse-connection-pool for each host(the default value is 2). This leads to slow batch files processing and TCP connections exceeding the system configuration limit.
What is changed and how it works?
set the
MaxIdleConnsPerHostas the same asMaxIdleConns.Check List
Tests
before configuration
after configuration
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.