Skip to content

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2196 (#45945)#46066

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-5.3from
ti-chi-bot:cherry-pick-45945-to-release-5.3
Closed

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2196 (#45945)#46066
ti-chi-bot wants to merge 1 commit intopingcap:release-5.3from
ti-chi-bot:cherry-pick-45945-to-release-5.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 14, 2023

This is an automated cherry-pick of #45945

What problem does this PR solve?

Issue Number: close #38361

Problem Summary: When compare datetime/timestamp column with numeric constant, try convert numeric constant to timestamp datetime, do nothing if conversion failed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@yibin87 @ti-chi-bot
This is an automated cherry-pick of pingcap#45945
14ca11c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Aug 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 14, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrysan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@windtalker
Copy link
Contributor

windtalker commented Aug 15, 2023

close it as will fix from v5.4.x

@windtalker windtalker closed this Aug 15, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-45945-to-release-5.3 branch April 15, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yibin87 yibin87

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @windtalker @yibin87