ddl: Exchange partition rollback (#45877)#45982
ddl: Exchange partition rollback (#45877)#45982ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This pull request is closed because its related version has closed automatic cherry-picking. https://prow.tidb.net/command-help#cherrypick |
This is an automated cherry-pick of #45877
What problem does this PR solve?
Issue Number: close #45791, close #45920
Problem Summary:
The first schema change state adds a restriction to the non-partitioned table, so that it can only write (insert/update) rows that would fit into the partition to be exchanged with. But if something fails afterwards, this is never cleared.
What is changed and how it works?
Adding rollback, in case of user cancellation or failure during the DDL execution, after the first state change.
Check List
Tests
Manual test for upgrade scenario, revert the changes made to
ddl/ddl_worker.go(which sets thediffstruct) and run the tests manually.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.