Skip to content

*: upgrade go1.21#45923

Merged
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
hawkingrei:120release
Aug 9, 2023
Merged

*: upgrade go1.21#45923
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
hawkingrei:120release

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 8, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45925

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
update
aaea8cf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@hawkingrei
*: upgrade go1.20
087c877 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go1.20
7eecf64 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@hawkingrei
*: upgrade go1.20
7c76b86 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2023
@hawkingrei
*: upgrade go1.20
3c9a15a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2023
@hawkingrei
*: upgrade go1.20
e460753 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go1.20
093932e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 8, 2023
@hawkingrei
Copy link
Member Author

hawkingrei commented Aug 8, 2023

/retest

@hawkingrei
*: upgrade go1.20
6c5e11e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #45923 (f22694f) into master (cdeac4c) will increase coverage by 0.0059%.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45923        +/-   ##
================================================
+ Coverage   73.3497%   73.3556%   +0.0059%     
================================================
  Files          1277       1280         +3     
  Lines        393388     394065       +677     
================================================
+ Hits         288549     289069       +520     
- Misses        86440      86566       +126     
- Partials      18399      18430        +31
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3474% <ø> (-0.0023%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0473% <ø> (+0.0108%) ⬆️
br 51.9980% <ø> (-0.0395%) ⬇️

@hawkingrei hawkingrei mentioned this pull request Aug 8, 2023
Merged
@hawkingrei
Copy link
Member Author

hawkingrei commented Aug 8, 2023

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

hawkingrei commented Aug 8, 2023

/retest

@hawkingrei
*: upgrade go1.20
a6e7dc3 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go1.20
6d012bf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go1.20
8483b2e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei mentioned this pull request Aug 9, 2023
Closed
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2023
@hawkingrei hawkingrei requested a review from bb7133 August 9, 2023 01:23
@hawkingrei
*: upgrade go1.21
2c5f306 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-09 01:21:20.07441538 +0000 UTC m=+75644.623431367: ☑️ agreed by lance6716.
  • 2023-08-09 01:34:43.958292275 +0000 UTC m=+76448.507308277: ☑️ agreed by Defined2014.

@hawkingrei
Copy link
Member Author

hawkingrei commented Aug 9, 2023

/retest

wuhuizuo
wuhuizuo reviewed Aug 9, 2023
View reviewed changes
@hawkingrei
*: upgrade go1.21
768992b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go1.21
f22694f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

hawkingrei commented Aug 9, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit ff3b9c0 into pingcap:master Aug 9, 2023
@hawkingrei hawkingrei deleted the 120release branch August 9, 2023 03:07
@crazycs520 crazycs520 mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuhuizuo wuhuizuo wuhuizuo left review comments

@lance6716 lance6716 lance6716 approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

upgrade go1.21

4 participants

@hawkingrei @lance6716 @wuhuizuo @Defined2014