Skip to content

planner: refine tryToGetIndexJoin (#45587)#45712

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-45587-to-release-6.5
Aug 1, 2023
Merged

planner: refine tryToGetIndexJoin (#45587)#45712
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-45587-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 1, 2023

This is an automated cherry-pick of #45587

What problem does this PR solve?

Issue Number: ref #45520

Problem Summary: planner: refine tryToGetIndexJoin

What is changed and how it works?

planner: refine tryToGetIndexJoin

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#45587
ff06a1a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-45587-to-release-6.5 branch from 1ef8605 to ff06a1a Compare August 1, 2023 07:09
@ti-chi-bot ti-chi-bot added epic/hint release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 1, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Aug 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 1, 2023
@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2023

/test all

@tiprow
Copy link

tiprow bot commented Aug 1, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2023
@hawkingrei
Copy link
Member

hawkingrei commented Aug 1, 2023

/test all

@tiprow
Copy link

tiprow bot commented Aug 1, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 07:28:16.972338882 +0000 UTC m=+170380.914687408: ☑️ agreed by time-and-fate.
  • 2023-08-01 07:39:45.652878414 +0000 UTC m=+171069.595226932: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

hawkingrei commented Aug 1, 2023

/retest

@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@05d7505). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #45712   +/-   ##
================================================
  Coverage               ?   73.6987%           
================================================
  Files                  ?       1082           
  Lines                  ?     347212           
  Branches               ?          0           
================================================
  Hits                   ?     255891           
  Misses                 ?      74902           
  Partials               ?      16419

@hawkingrei
Copy link
Member

hawkingrei commented Aug 1, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0adf0ac into pingcap:release-6.5 Aug 1, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-45587-to-release-6.5 branch April 15, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees

@qw4990 qw4990

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. epic/hint lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @qw4990 @hawkingrei @time-and-fate