Skip to content

ddl: cancel create view job , when failed to drop old view (#40353)#45685

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20230731-v6.5.3from
qw4990:pick-40353
Jul 31, 2023
Merged

ddl: cancel create view job , when failed to drop old view (#40353)#45685
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20230731-v6.5.3from
qw4990:pick-40353

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 31, 2023

This is an automated cherry-pick of #40353

Signed-off-by: zeminzhou zhouzemin@pingcap.com

What problem does this PR solve?

Issue Number: close #40352

Problem Summary:

What is changed and how it works?

cancel create view job , when failed to drop old view

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

No

Documentation

No

Release note

cancel `create view` job , when failed to drop old view

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2023
@tiprow
Copy link

tiprow bot commented Jul 31, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elsa0520
elsa0520 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

@elsa0520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 07:21:19.216971284 +0000 UTC m=+83563.159319808: ☑️ agreed by time-and-fate.
  • 2023-07-31 07:30:42.475387098 +0000 UTC m=+84126.417735652: ☑️ agreed by hawkingrei.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 31, 2023

/rebuild

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 31, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 31, 2023

/test build

@tiprow
Copy link

tiprow bot commented Jul 31, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Jul 31, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230731-v6.5.3@71e6696). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-6.5-20230731-v6.5.3     #45685   +/-   ##
================================================================
  Coverage                               ?   73.4219%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346421           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254349           
  Misses                                 ?      75652           
  Partials                               ?      16420

@ti-chi-bot ti-chi-bot bot merged commit 11944ee into pingcap:release-6.5-20230731-v6.5.3 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@AilinKid AilinKid AilinKid approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@elsa0520 elsa0520 elsa0520 approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qw4990 @hawkingrei @AilinKid @time-and-fate @elsa0520 @zeminzhou