Skip to content

store: Don't set limit for GetRegionsInfoByRange function (#45556)#45572

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-45556-to-release-6.5
Jul 26, 2023
Merged

store: Don't set limit for GetRegionsInfoByRange function (#45556)#45572
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-45556-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 26, 2023

This is an automated cherry-pick of #45556

What problem does this PR solve?

Issue Number: close #45531

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> select tidb_table_id from information_schema.tables where table_schema='test' and table_name='t1';
+---------------+
| tidb_table_id |
+---------------+
|            96 |
+---------------+
1 row in set (0.01 sec)

mysql> select region_id, is_index, start_key from information_schema.tikv_region_status where table_id = 96;
+-----------+----------+--------------------------------------------------------+
| region_id | is_index | start_key                                              |
+-----------+----------+--------------------------------------------------------+
|       154 |        0 | 7480000000000000FF605F720173000000FF0000000000000000FB |
|       160 |        0 | 7480000000000000FF605F720176000000FF0000000000000000FB |
|       162 |        0 | 7480000000000000FF605F720177000000FF0000000000000000FB |
|       118 |        1 | 7480000000000000FF6000000000000000F8                   |
|       118 |        0 | 7480000000000000FF6000000000000000F8                   |
|       124 |        0 | 7480000000000000FF605F720164000000FF0000000000000000FB |
|       140 |        0 | 7480000000000000FF605F72016C000000FF0000000000000000FB |
|       142 |        0 | 7480000000000000FF605F72016D000000FF0000000000000000FB |
|       156 |        0 | 7480000000000000FF605F720174000000FF0000000000000000FB |
|       130 |        0 | 7480000000000000FF605F720167000000FF0000000000000000FB |
|       134 |        0 | 7480000000000000FF605F720169000000FF0000000000000000FB |
|       138 |        0 | 7480000000000000FF605F72016B000000FF0000000000000000FB |
|       144 |        0 | 7480000000000000FF605F72016E000000FF0000000000000000FB |
|       136 |        0 | 7480000000000000FF605F72016A000000FF0000000000000000FB |
|       146 |        0 | 7480000000000000FF605F72016F000000FF0000000000000000FB |
|       150 |        0 | 7480000000000000FF605F720171000000FF0000000000000000FB |
|        22 |        0 | 7480000000000000FF605F720179000000FF0000000000000000FB |
|       132 |        0 | 7480000000000000FF605F720168000000FF0000000000000000FB |
|       148 |        0 | 7480000000000000FF605F720170000000FF0000000000000000FB |
|       152 |        0 | 7480000000000000FF605F720172000000FF0000000000000000FB |
|       158 |        0 | 7480000000000000FF605F720175000000FF0000000000000000FB |
|       120 |        0 | 7480000000000000FF605F720162000000FF0000000000000000FB |
|       122 |        0 | 7480000000000000FF605F720163000000FF0000000000000000FB |
|       126 |        0 | 7480000000000000FF605F720165000000FF0000000000000000FB |
|       128 |        0 | 7480000000000000FF605F720166000000FF0000000000000000FB |
|       164 |        0 | 7480000000000000FF605F720178000000FF0000000000000000FB |
+-----------+----------+--------------------------------------------------------+
26 rows in set (0.01 sec)

mysql> select region_id, is_index, start_key from information_schema.tikv_region_status where db_name = 'test' and table_name = 't1';
+-----------+----------+--------------------------------------------------------+
| region_id | is_index | start_key                                              |
+-----------+----------+--------------------------------------------------------+
|       140 |        0 | 7480000000000000FF605F72016C000000FF0000000000000000FB |
|        22 |        0 | 7480000000000000FF605F720179000000FF0000000000000000FB |
|       120 |        0 | 7480000000000000FF605F720162000000FF0000000000000000FB |
|       122 |        0 | 7480000000000000FF605F720163000000FF0000000000000000FB |
|       130 |        0 | 7480000000000000FF605F720167000000FF0000000000000000FB |
|       158 |        0 | 7480000000000000FF605F720175000000FF0000000000000000FB |
|       162 |        0 | 7480000000000000FF605F720177000000FF0000000000000000FB |
|       134 |        0 | 7480000000000000FF605F720169000000FF0000000000000000FB |
|       146 |        0 | 7480000000000000FF605F72016F000000FF0000000000000000FB |
|       156 |        0 | 7480000000000000FF605F720174000000FF0000000000000000FB |
|       164 |        0 | 7480000000000000FF605F720178000000FF0000000000000000FB |
|       132 |        0 | 7480000000000000FF605F720168000000FF0000000000000000FB |
|       150 |        0 | 7480000000000000FF605F720171000000FF0000000000000000FB |
|       124 |        0 | 7480000000000000FF605F720164000000FF0000000000000000FB |
|       144 |        0 | 7480000000000000FF605F72016E000000FF0000000000000000FB |
|       126 |        0 | 7480000000000000FF605F720165000000FF0000000000000000FB |
|       152 |        0 | 7480000000000000FF605F720172000000FF0000000000000000FB |
|       160 |        0 | 7480000000000000FF605F720176000000FF0000000000000000FB |
|       136 |        0 | 7480000000000000FF605F72016A000000FF0000000000000000FB |
|       148 |        0 | 7480000000000000FF605F720170000000FF0000000000000000FB |
|       118 |        1 | 7480000000000000FF6000000000000000F8                   |
|       118 |        0 | 7480000000000000FF6000000000000000F8                   |
|       142 |        0 | 7480000000000000FF605F72016D000000FF0000000000000000FB |
|       154 |        0 | 7480000000000000FF605F720173000000FF0000000000000000FB |
|       128 |        0 | 7480000000000000FF605F720166000000FF0000000000000000FB |
|       138 |        0 | 7480000000000000FF605F72016B000000FF0000000000000000FB |
+-----------+----------+--------------------------------------------------------+
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 26, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-45556-to-release-6.5 branch from d48000a to 7f6a0bd Compare July 26, 2023 01:34
@Defined2014 Defined2014 requested review from hawkingrei and xhebox July 26, 2023 01:38
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@b852d16). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #45572   +/-   ##
================================================
  Coverage               ?   73.4299%           
================================================
  Files                  ?       1080           
  Lines                  ?     346657           
  Branches               ?          0           
================================================
  Hits                   ?     254550           
  Misses                 ?      75662           
  Partials               ?      16445

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-26 02:25:20.753875441 +0000 UTC m=+321263.348406424: ☑️ agreed by xhebox.
  • 2023-07-26 02:28:49.411474742 +0000 UTC m=+321472.006005715: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit ff34755 into pingcap:release-6.5 Jul 26, 2023
@Defined2014 Defined2014 deleted the cherry-pick-45556-to-release-6.5 branch August 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees

@Defined2014 Defined2014

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @xhebox @Defined2014