lightning: fix lightning failed to log encoding error (#45241)#45364
Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-6.5from Jul 24, 2023
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Contributor
|
/cc @lance6716 |
lance6716
approved these changes
Jul 20, 2023
Contributor
|
/cc @D3Hunter |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45364 +/- ##
================================================
Coverage ? 73.4470%
================================================
Files ? 1080
Lines ? 347039
Branches ? 0
================================================
Hits ? 254890
Misses ? 75686
Partials ? 16463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45241
What problem does this PR solve?
Issue Number: close #44321
Problem Summary:
When the source file has ill-formated row, the row is very large so it can't be logged. We can't locate the bad row;
What is changed and how it works?
When we encounter ill-formatted row, we take out the ill-formatted row and only log the first 1024 characters of the row, so that it would not report error that write length exceeds maximum file size.
Before fixing the issue, the log looks like this when encountering ill-formatted row:
The length of the row is 324.
After fixing the issue, the log looks like this when encountering ill-formatted row:
The length of the row is 2419.
So to check whether the "exceeds maximum file size" issue has been fixed, we could check whether the length of the row is larger than 500, which can make sure the log shows the first 1024 characters of the ill-formatted row instead of saying "write error: write length xxx exceeds maximum file size xxx".
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.