Skip to content

planner, executor: fix the logic for inline projection of executors (#45158)#45333

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-45158-to-release-7.1
Jul 12, 2023
Merged

planner, executor: fix the logic for inline projection of executors (#45158)#45333
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-45158-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45158

What problem does this PR solve?

Issue Number: close #45112

Problem Summary:

What is changed and how it works?

The Physical Projection Elimination permits the case that the parent plan has a column which cannot be found by the child(ren).

The only thing we can rely on during the execution phase is the Column.Index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jul 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-12 11:06:06.844473038 +0000 UTC m=+502858.614811814: ☑️ agreed by elsa0520.
  • 2023-07-12 11:40:47.377092419 +0000 UTC m=+504939.147431122: ☑️ agreed by time-and-fate.

@winoros winoros force-pushed the cherry-pick-45158-to-release-7.1 branch from 0fe679e to d119f83 Compare July 12, 2023 11:48
@winoros
Copy link
Member

winoros commented Jul 12, 2023

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, fixdb, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@winoros
Copy link
Member

winoros commented Jul 12, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0fa3186 into pingcap:release-7.1 Jul 12, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-45158-to-release-7.1 branch April 15, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants