*: support time function for `calibrate resource` by CabinfeverB · Pull Request #44965 · pingcap/tidb

CabinfeverB · 2023-06-26T15:01:47Z

What problem does this PR solve?

Issue Number: close #44908

Problem Summary:

What is changed and how it works?

support time function for calibrate resource , such as date_sub(now(), interval 10 minute)
support to input duration only which means starting from now() - duration to now()
move file to internal
and fix test bug which is because of no filter in mock metrics data

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

tiprow · 2023-06-26T15:02:14Z

Hi @CabinfeverB. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CabinfeverB · 2023-06-26T15:03:08Z

cc @glorv @nolouch

hawkingrei · 2023-06-26T15:45:13Z

/ok-to-test

hawkingrei · 2023-06-26T16:06:38Z

/retest

hawkingrei · 2023-06-26T16:09:55Z

/retest

hawkingrei · 2023-06-26T16:37:44Z

/test tiprow_fast_test

ti-chi-bot · 2023-06-26T16:37:46Z

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-integration-br-test
/test pull-integration-mysql-test
/test unit-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

Details

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

glorv · 2023-06-27T02:16:23Z

parser/parser.y

 		$$ = &ast.DynamicCalibrateResourceOption{Tp: ast.CalibrateDuration, StrValue: $3}
 	}

+DynamicCalibrateTimeOption:


What about treat this option as a expr field that can accept any expr that can be evaluated as time

+1, directly Expression

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

nolouch

lgtm

ti-chi-bot · 2023-07-10T09:08:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [glorv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-07-10T09:08:37Z

[LGTM Timeline notifier]

Timeline:

2023-07-10 02:43:30.248388991 +0000 UTC m=+299902.018727705: ☑️ agreed by glorv.
2023-07-10 09:08:36.413589941 +0000 UTC m=+323008.183928654: ☑️ agreed by nolouch.

nolouch · 2023-07-10T09:08:45Z

/test pull-br-integration-test

tiprow · 2023-07-10T09:09:02Z

@nolouch: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CabinfeverB · 2023-07-11T03:13:11Z

/test pull-br-integration-test

tiprow · 2023-07-11T03:13:41Z

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CabinfeverB added 2 commits June 26, 2023 22:48

support time function for calibrate

12b1f26

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

merge master

7cd36ef

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 26, 2023

CabinfeverB mentioned this pull request Jun 27, 2023

calibrate: shorten the minimum calibrate duration #44972

Merged

12 tasks

glorv reviewed Jun 27, 2023

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023

CabinfeverB added 4 commits June 30, 2023 17:05

merge master

8b7f6a7

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

address comment

c0c0d1b

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

merge master

06a60b8

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

move pkg

17496ff

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023

update bazel

fe51d42

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023

update bazel

3f55ba4

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023

CabinfeverB added 2 commits July 4, 2023 20:24

fix bug

f765a5b

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix lint

a28542e

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB added 3 commits July 4, 2023 20:33

fix lint

205c1cb

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix test

b7ecd40

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

fix test

2c5972b

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023

glorv approved these changes Jul 10, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 10, 2023

nolouch approved these changes Jul 10, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 10, 2023

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 11, 2023

ti-chi-bot bot merged commit e048e9e into pingcap:master Jul 11, 2023

ti-chi-bot mentioned this pull request Aug 11, 2023

calibrate: shorten the minimum calibrate duration (#44972) #46007

Merged

12 tasks

Conversation

CabinfeverB commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

tiprow bot commented Jun 26, 2023

Uh oh!

CabinfeverB commented Jun 26, 2023

Uh oh!

hawkingrei commented Jun 26, 2023

Uh oh!

hawkingrei commented Jun 26, 2023

Uh oh!

hawkingrei commented Jun 26, 2023

Uh oh!

hawkingrei commented Jun 26, 2023

Uh oh!

ti-chi-bot bot commented Jun 26, 2023

Uh oh!

glorv Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

nolouch Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

nolouch left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jul 10, 2023

Uh oh!

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Uh oh!

nolouch commented Jul 10, 2023

Uh oh!

tiprow bot commented Jul 10, 2023

Uh oh!

CabinfeverB commented Jul 11, 2023

Uh oh!

tiprow bot commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CabinfeverB commented Jun 26, 2023 •

edited

Loading