*: label external the request source via sessionvar by nolouch · Pull Request #44770 · pingcap/tidb

nolouch · 2023-06-19T04:20:25Z

What problem does this PR solve?

Issue Number: ref #44769

Problem Summary:

currently, we cannot know requests from external tools, like using the lightning-cli with tidb backend model to import data.

What is changed and how it works?

add a sessionvar to complement the RequestSourceType.
- external tools need start a session with setting the variable, then label the source origin

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-06-19T04:20:27Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

distsql/request_builder.go

sessionctx/variable/tidb_vars.go

Signed-off-by: nolouch <nolouch@gmail.com>

glorv · 2023-07-07T08:56:28Z

/cc @bb7133 @BornChanger

ti-chi-bot · 2023-07-10T06:04:44Z

@glorv: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-07-10T09:48:01Z

[LGTM Timeline notifier]

Timeline:

2023-07-07 08:55:43.530405399 +0000 UTC m=+63035.300744111: ☑️ agreed by glorv.
2023-07-10 09:48:00.360071065 +0000 UTC m=+325372.130409778: ☑️ agreed by crazycs520.

ti-chi-bot · 2023-07-10T10:26:34Z

@nolouch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	760984b486d842ab84494b9411b5a1f0fc384b70	link	true	`/test pull-br-integration-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nolouch · 2023-07-10T13:09:56Z

/retest-required

nolouch · 2023-07-10T14:52:35Z

ptal @bb7133

hawkingrei · 2023-07-11T02:00:35Z

/hold

hawkingrei · 2023-07-11T02:00:53Z

/unhold

hawkingrei · 2023-07-11T03:48:12Z

/hold

hawkingrei · 2023-07-11T03:49:15Z

/unhold

ti-chi-bot · 2023-07-11T04:20:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, glorv, HuSharp, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [crazycs520,glorv,qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nolouch requested review from HuSharp and glorv June 19, 2023 04:20

nolouch changed the title ~~lightning: label the request source in tidb backend~~ *: label the request source via tidb Jun 29, 2023

nolouch force-pushed the background-label branch from 1444e2c to 6f4c0c7 Compare June 29, 2023 01:48

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023

nolouch force-pushed the background-label branch from 6f4c0c7 to 4b608d7 Compare June 29, 2023 19:47

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2023

nolouch force-pushed the background-label branch from 4b608d7 to e67b75e Compare July 4, 2023 05:57

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2023

HuSharp reviewed Jul 4, 2023

View reviewed changes

distsql/request_builder.go Outdated Show resolved Hide resolved

HuSharp reviewed Jul 4, 2023

View reviewed changes

sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023

*: customize the request type by sysvar

07791ab

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the background-label branch from e67b75e to 07791ab Compare July 5, 2023 08:01

address

0ca104a

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the background-label branch from 2deabb3 to 0ca104a Compare July 5, 2023 09:31

Merge remote-tracking branch 'origin/master' into request-source-var

0ba84ca

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2023

nolouch marked this pull request as ready for review July 5, 2023 09:37

nolouch requested a review from a team as a code owner July 5, 2023 09:37

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023

nolouch changed the title *: label the request source via tidb *: label external the request source via sessionvar Jul 5, 2023

update

b6614c9

Signed-off-by: nolouch <nolouch@gmail.com>

ti-chi-bot bot added the approved label Jul 7, 2023

ti-chi-bot bot requested review from BornChanger and bb7133 July 7, 2023 08:56

glorv approved these changes Jul 10, 2023

View reviewed changes

crazycs520 approved these changes Jul 10, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 10, 2023

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023

qw4990 approved these changes Jul 11, 2023

View reviewed changes

ti-chi-bot bot merged commit 3aa21d0 into pingcap:master Jul 11, 2023

nolouch deleted the background-label branch July 11, 2023 06:13

This was referenced Jul 24, 2023

executor: add explicit request source for point get request #45526

Merged

Tracking Issue of Background Resource Control #44517

Closed

Conversation

nolouch commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Jun 19, 2023

Uh oh!

Uh oh!

Uh oh!

glorv commented Jul 7, 2023

Uh oh!

ti-chi-bot bot commented Jul 10, 2023

Uh oh!

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nolouch commented Jul 10, 2023

Uh oh!

nolouch commented Jul 10, 2023

Uh oh!

hawkingrei commented Jul 11, 2023

Uh oh!

hawkingrei commented Jul 11, 2023

Uh oh!

hawkingrei commented Jul 11, 2023

Uh oh!

hawkingrei commented Jul 11, 2023

Uh oh!

ti-chi-bot bot commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nolouch commented Jun 19, 2023 •

edited

Loading

ti-chi-bot bot commented Jul 10, 2023 •

edited

Loading