statistics: remove h.mu.Lock when creating NewSessionStatsCollector (#44510)#44515
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from Jun 8, 2023
Conversation
12 tasks
chrysan
approved these changes
Jun 8, 2023
AilinKid
approved these changes
Jun 8, 2023
hawkingrei
approved these changes
Jun 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, chrysan, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, chrysan, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44510
What problem does this PR solve?
Issue Number: close #44502
Problem Summary:
What is changed and how it works?
We don't need to
h.mu.Lockwhen creatingNewSessionStatsCollectororNewSessionIndexUsageCollector.Check List
Tests
Use
time.Sleepto simulate slow internal sql indumpTableStatCountToKV. WhendumpTableStatCountToKVis holdingh.mu, MySQL client can still establish connection with TiDB server.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.