Skip to content

copr: support choose non pending tiflash peer when dispatch MPPTask#44222

Open
guo-shaoge wants to merge 1 commit intopingcap:masterfrom
guo-shaoge:tiflash_peending_peer
Open

copr: support choose non pending tiflash peer when dispatch MPPTask#44222
guo-shaoge wants to merge 1 commit intopingcap:masterfrom
guo-shaoge:tiflash_peending_peer

Conversation

@guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented May 28, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44221

Problem Summary: As issue said, we want to consider tiflash replica pending status when dispatch MPPTask

What is changed and how it works?

  1. Support get pending tiflash peer store, most changes are in region_cache: support check pending tiflash peer tikv/client-go#821
  2. Choose nonPending stores as balance candidate, otherwise use allStores.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@guo-shaoge
copr: support select non pending tiflash peer
af9318c 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2023
@guo-shaoge guo-shaoge changed the title copr: support select non pending tiflash peer copr: support choose non pending tiflash peer when dispatch MPPTask May 28, 2023
@guo-shaoge guo-shaoge mentioned this pull request May 28, 2023
Merged
@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented May 28, 2023

Wait tikv/client-go#821 merge first

disksing
disksing reviewed Jun 5, 2023
View reviewed changes
store/copr/batch_coprocessor.go
// 1. Use `nonPendingStores` to avoid wait replica sync done.
// 2. Refresh region cache if still have pending peer.
allStores = nonPendingStores
if len(allStores) != len(nonPendingStores) {
Copy link
Contributor

@disksing disksing Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are always equal because they are the same slice.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guo-shaoge guo-shaoge closed this Jul 14, 2023
@guo-shaoge guo-shaoge reopened this Jul 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guo-shaoge. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Jul 14, 2023

will fix later

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 14, 2023
@tiprow
Copy link

tiprow bot commented Jul 14, 2023

@guo-shaoge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test af9318c link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2025

@guo-shaoge: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test af9318c link true /test mysql-test
pull-mysql-client-test af9318c link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/check_dev_2 af9318c link true /test check-dev2
pull-integration-ddl-test af9318c link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/build af9318c link true /test build
idc-jenkins-ci-tidb/check_dev af9318c link true /test check-dev
idc-jenkins-ci-tidb/unit-test af9318c link true /test unit-test
pull-br-integration-test af9318c link true /test pull-br-integration-test
pull-lightning-integration-test af9318c link true /test pull-lightning-integration-test
pull-integration-e2e-test af9318c link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen af9318c link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen af9318c link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing left review comments

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider region pending status when dispatch task

2 participants

@guo-shaoge @disksing