Skip to content

ddl/ingest: create new local backend if necessary (#44140)#44152

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-44140-to-release-7.1
Jul 7, 2023
Merged

ddl/ingest: create new local backend if necessary (#44140)#44152
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-44140-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 24, 2023

This is an automated cherry-pick of #44140

What problem does this PR solve?

Issue Number: close #44137, close #44044

Problem Summary:

See #44137 (comment).

What is changed and how it works?

If there is no writers in engine, it means the local backend is closed.

  • Reopen the local backend before retrying adding index.
  • Skip deleting SST files that belong to a running DDL job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#44140
307d15b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 24, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 24, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 24, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Jul 7, 2023

Please resolve conflict @tangenta

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot added the approved label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [tiancaiamao,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-07 06:22:49.223666353 +0000 UTC m=+53860.994005066: ☑️ agreed by wjhuang2016.
  • 2023-07-07 06:26:59.794171209 +0000 UTC m=+54111.564509922: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit df1d07e into pingcap:release-7.1 Jul 7, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-44140-to-release-7.1 branch April 15, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

@tangenta tangenta

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @tiancaiamao @wjhuang2016 @tangenta