Skip to content

sessionctx, executor: fix failure of reading MaxPreparedStmtCount (#39736) | tidb-test=pr/2117#43054

Merged
ti-chi-bot merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39736-to-release-6.5
Apr 14, 2023
Merged

sessionctx, executor: fix failure of reading MaxPreparedStmtCount (#39736) | tidb-test=pr/2117#43054
ti-chi-bot merged 4 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39736-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 14, 2023 •
edited by xuyifangreeneyes
Loading

This is an automated cherry-pick of #39736

Also, we cherry-pick #40024 to fix unstable TestMaxPreparedStmtCount.

What problem does this PR solve?

Issue Number: close #39735

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner April 14, 2023 05:21
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Apr 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 14, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 14, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2023
@xuyifangreeneyes
Copy link
Contributor

xuyifangreeneyes commented Apr 14, 2023

/test check-dev

fixdb
fixdb approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 14, 2023
@xuyifangreeneyes xuyifangreeneyes changed the title sessionctx, executor: fix failure of reading MaxPreparedStmtCount (#39736) sessionctx, executor: fix failure of reading MaxPreparedStmtCount (#39736) | tidb-test=pr/2117 Apr 14, 2023
@xuyifangreeneyes
Copy link
Contributor

xuyifangreeneyes commented Apr 14, 2023

/test mysql-test

@hawkingrei
Copy link
Member

hawkingrei commented Apr 14, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2c062e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2023
@ti-chi-bot ti-chi-bot merged commit fef9128 into pingcap:release-6.5 Apr 14, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test a706515 link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 21, 2023
@ran-huang ran-huang mentioned this pull request Apr 27, 2023
Merged
15 tasks
This was referenced Apr 27, 2023
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39736-to-release-6.5 branch April 15, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fixdb fixdb fixdb approved these changes

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

Assignees

@xuyifangreeneyes xuyifangreeneyes

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-chi-bot @xuyifangreeneyes @hawkingrei @fixdb @qw4990 @winoros @VelocityLight