Skip to content

lightning: check peers write stall when switch-mode is disabled (#40228)#42858

Merged
ti-chi-bot merged 3 commits intopingcap:release-6.5from
lance6716:cp1
Apr 10, 2023
Merged

lightning: check peers write stall when switch-mode is disabled (#40228)#42858
ti-chi-bot merged 3 commits intopingcap:release-6.5from
lance6716:cp1

Conversation

@lance6716
Copy link
Contributor

@lance6716 lance6716 commented Apr 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #40163

Problem Summary:

What is changed and how it works?

Manually cherry-pick #40228 and #42855

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 7, 2023
@lance6716
fix package name
bbf1cf1 
Signed-off-by: lance6716 <lance6716@gmail.com>
Benjamin2037
Benjamin2037 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 10, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Apr 10, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 10, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bbf1cf1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Apr 10, 2023

/retest

1 similar comment
@lance6716
Copy link
Contributor Author

lance6716 commented Apr 10, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit d750219 into pingcap:release-6.5 Apr 10, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023

@lance6716: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test bbf1cf1 link unknown /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lance6716 @ti-chi-bot @Benjamin2037 @tangenta @VelocityLight