Skip to content

planner: prepared plan cache support cached plan with placeholder in limit clause (#40196)#41644

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40196-to-release-6.5
Closed

planner: prepared plan cache support cached plan with placeholder in limit clause (#40196)#41644
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40196-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 22, 2023

This is an automated cherry-pick of #40196

What problem does this PR solve?

support limit in plan cache, the execution plan may vary with the limit offset and count, so if we want to use cache, we'd better encode the offset and count into plan cache key to ensure the plan's correctness
Issue Number: ref #40219

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@fzzf678 @ti-chi-bot
This is an automated cherry-pick of pingcap#40196
07fe172 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 22, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Feb 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added epic/plan-cache sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 22, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 22, 2023

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 07fe172 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 07fe172 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 07fe172 link true /test check-dev2
idc-jenkins-ci-tidb/build 07fe172 link true /test build

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fzzf678
Copy link
Contributor

fzzf678 commented Feb 22, 2023

Wrongly labeled

@fzzf678 fzzf678 closed this Feb 22, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 22, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40196-to-release-6.5 branch April 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fzzf678 fzzf678

Labels

cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @fzzf678 @VelocityLight