Skip to content

br: remove totalFlashbackRegions since task completion region already contains all regions (#40504)#41433

Merged
ti-chi-bot merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40504-to-release-6.5
Feb 15, 2023
Merged

br: remove totalFlashbackRegions since task completion region already contains all regions (#40504)#41433
ti-chi-bot merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40504-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 15, 2023

This is an automated cherry-pick of #40504

What problem does this PR solve?

Issue Number: close #40391 #41005

Problem Summary:

What is changed and how it works?

refactoring code to remove totalFlashbackRegions since task completion region already contains all regions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. follow the doc https://docs.pingcap.com/zh/tidb-in-kubernetes/stable/backup-to-aws-s3-by-snapshot to do the backup
  2. follow the doc https://docs.pingcap.com/zh/tidb-in-kubernetes/stable/restore-from-aws-s3-by-snapshot to do the restore
  3. restore success
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@fengou1 @ti-chi-bot
This is an automated cherry-pick of pingcap#40504
9884380 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. component/br This issue is related to BR of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 15, 2023
@fengou1 fengou1 requested review from Leavrth and joccau February 15, 2023 07:57
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2023
@fengou1
Copy link
Contributor

fengou1 commented Feb 15, 2023

/test unit-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 15, 2023
joccau
joccau approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2023
@joccau
Copy link
Contributor

joccau commented Feb 15, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 15, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 63fca7c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@ti-chi-bot ti-chi-bot merged commit f1ad67c into pingcap:release-6.5 Feb 15, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Mar 13, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40504-to-release-6.5 branch April 15, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leavrth Leavrth Leavrth approved these changes

+1 more reviewer

@joccau joccau joccau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fengou1 fengou1

Labels

component/br This issue is related to BR of TiDB. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @fengou1 @joccau @Leavrth @VelocityLight