Skip to content

log-backup: added cache for sst_importer client (#41305)#41338

Merged
ti-chi-bot merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-41305-to-release-6.5
Feb 13, 2023
Merged

log-backup: added cache for sst_importer client (#41305)#41338
ti-chi-bot merged 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-41305-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #41305

Signed-off-by: hillium yujuncen@pingcap.com

What problem does this PR solve?

Issue Number: close #41328

Problem Summary:
There are too many tiny files while doing log restore, however the import API is stateless, hence we must create one TLS connection for each download, which has poor performance.

What is changed and how it works?

This PR added cache for log restore. It have reused the cache functionality of full restore.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    img_v2_d44f8373-a93f-4820-b0b8-663e6d70cd7g

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Now, PITR uses less CPU.

Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • YuJuncen
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. do-not-merge/cherry-pick-not-approved labels Feb 13, 2023
Copy link
Contributor

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
Copy link
Contributor

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 13, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 13, 2023
@joccau
Copy link
Contributor

joccau commented Feb 13, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 51d84eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@joccau
Copy link
Contributor

joccau commented Feb 13, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 31c3869 into pingcap:release-6.5 Feb 13, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-41305-to-release-6.5 branch April 15, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants