statistics: remove 1min no write check for unanalyzed table in auto analyze (#39395)#41229
statistics: remove 1min no write check for unanalyzed table in auto analyze (#39395)#41229ti-chi-bot wants to merge 2 commits intopingcap:release-6.1from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
statistics/handle/update.go
Outdated
| func NeedAnalyzeTable(tbl *statistics.Table, limit time.Duration, autoAnalyzeRatio float64) (bool, string) { | ||
| analyzed := TableAnalyzed(tbl) | ||
| if !analyzed { | ||
| <<<<<<< HEAD |
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This pull request is closed because its related version has closed automatic cherry-picking. https://prow.tidb.net/command-help#cherrypick |
This is an automated cherry-pick of #39395
What problem does this PR solve?
Issue Number: close #43437
Problem Summary:
What is changed and how it works?
Same as #39179
When we decide whether a table needs to be auto analzyzed, if the table has never been analyzed and there is no write to the table in the last minute, we trigger auto analyze for the table. The condition of no write in the last minute may prevent the table from auto analyze and the optimizer may choose wrong plans using pseudo stats. Hence the pr removes the condition. The condition of no write in the last minute was first introduced for the following case. When loading data, auto analyze v1 is triggered and preempts CPU and other resources with loading data. However, after auto analyze v2 is introduced, the resource consumption of analyze is reduced so it would not be a problem to trigger auto analyze when loading data.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.