Skip to content

session: Do not run telemetry loops when it's disabled in config (#40156)#41147

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-40156-to-release-6.1
Closed

session: Do not run telemetry loops when it's disabled in config (#40156)#41147
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-40156-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 7, 2023

This is an automated cherry-pick of #40156

Telemetry can not be enabled by global variable when it's disabled in config file. Therefore we don't need to run telemetry related loops at all when telemetry is disable from global config.

Signed-off-by: Xiaoguang Sun sunxiaoguang@gmail.com

What problem does this PR solve?

Issue Number: close #40155

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@sunxiaoguang @ti-chi-bot
This is an automated cherry-pick of pingcap#40156
d9b0e3f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 7, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 7, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 7, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Feb 7, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 7, 2023

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev d9b0e3f link true /test check-dev
idc-jenkins-ci-tidb/unit-test d9b0e3f link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 d9b0e3f link true /test check-dev2
idc-jenkins-ci-tidb/build d9b0e3f link true /test build
idc-jenkins-ci-tidb/mysql-test d9b0e3f link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dveeden dveeden mentioned this pull request Feb 7, 2023
Merged
12 tasks
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Mar 29, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40156-to-release-6.1 branch April 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sunxiaoguang sunxiaoguang

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @sunxiaoguang @VelocityLight