telemetry: Log error reason for failure to get SQL Metric (#40778)#41138
Conversation
With JSON formatted logs:
```
$ jq 'select(.error) | select(.error | contains("Prometheus"))' tidb.log
{
"level": "INFO",
"time": "2023/01/27 10:00:35.554 +01:00",
"caller": "data_slow_query.go:67",
"message": "Failed to get Slow Query Stats",
"error": "[domain:9009]Prometheus address is not set in PD and etcd"
}
{
"level": "INFO",
"time": "2023/01/27 10:01:36.223 +01:00",
"caller": "data_window.go:257",
"message": "Error exists when getting the SQL Metric.",
"error": "[domain:9009]Prometheus address is not set in PD and etcd"
}
{
"level": "INFO",
"time": "2023/01/27 10:02:36.225 +01:00",
"caller": "data_window.go:257",
"message": "Error exists when getting the SQL Metric.",
"error": "[domain:9009]Prometheus address is not set in PD and etcd"
}
```
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/retest |
1 similar comment
|
/retest |
|
/hold high priority for trunk branch |
|
/unhold |
|
/merge |
|
@dveeden: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 1c5dea8 |
This is an automated cherry-pick of #40778
What problem does this PR solve?
Issue Number: close #40777
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
With this PR:
Without this PR: