Skip to content

ddl, statistics: fix stats meta missing when creating many tables at once (#38301)#41010

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-38301-to-release-6.5
Dec 11, 2023
Merged

ddl, statistics: fix stats meta missing when creating many tables at once (#38301)#41010
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-38301-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 2, 2023

This is an automated cherry-pick of #38301

What problem does this PR solve?

Issue Number: close #38189 close #36004

Problem Summary:

What is changed and how it works?

If the stats meta is not inserted after creating the table, we insert it in DumpStatsDeltaToKV(use INSERT INTO ... ON DUPLICATE KEY UPDATE ...).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 2, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Feb 2, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 2, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 2, 2023
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 10, 2023

/hold high priority for trunk branch

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 10, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Aug 10, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#38301
e4b72e5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-38301-to-release-6.5 branch from 15f45c6 to e4b72e5 Compare December 7, 2023 07:47
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-11 07:51:40.183547 +0000 UTC m=+256191.220773927: ☑️ agreed by qw4990.
  • 2023-12-11 08:21:46.305079642 +0000 UTC m=+257997.342306760: ☑️ agreed by time-and-fate.

@time-and-fate
Copy link
Member

time-and-fate commented Dec 11, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2023

@time-and-fate: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 11, 2023
@codecov
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@8445821). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #41010   +/-   ##
================================================
  Coverage               ?   73.6211%           
================================================
  Files                  ?       1087           
  Lines                  ?     349485           
  Branches               ?          0           
================================================
  Hits                   ?     257295           
  Misses                 ?      75660           
  Partials               ?      16530

@ti-chi-bot ti-chi-bot bot merged commit 859fade into pingcap:release-6.5 Dec 11, 2023
@Lloyd-Pottiger Lloyd-Pottiger deleted the cherry-pick-38301-to-release-6.5 branch December 26, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees

@xuyifangreeneyes xuyifangreeneyes

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @wuhuizuo @time-and-fate @qw4990 @xuyifangreeneyes @elsa0520