Skip to content

executor: Fix tidb crash on index merge reader (#40904)#40983

Closed
ti-chi-bot wants to merge 3 commits intopingcap:release-5.3from
ti-chi-bot:cherry-pick-40904-to-release-5.3
Closed

executor: Fix tidb crash on index merge reader (#40904)#40983
ti-chi-bot wants to merge 3 commits intopingcap:release-5.3from
ti-chi-bot:cherry-pick-40904-to-release-5.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 2, 2023

This is an automated cherry-pick of #40904

What problem does this PR solve?

Issue Number: close #40877

Problem Summary:

What is changed and how it works?

Let both pickAndExecTask and handlePickAndExecTaskPanic take the address of task as its argument, so once *task is assigned in pickAndExecTask, handlePickAndExecTaskPanic will get a non nil value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#40904
37667b6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 2, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 2, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-40904-to-release-5.3 branch from 820bf77 to 37667b6 Compare February 2, 2023 07:14
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Feb 2, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 2, 2023

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@windtalker
Copy link
Contributor

windtalker commented Feb 9, 2023

Close as major bug is not needed the cherry pick unless there is a customer waiting this.

@windtalker windtalker closed this Feb 9, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40904-to-release-5.3 branch April 15, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@windtalker windtalker

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @windtalker