expression, cmd: fix ColumnSubstitute and allow some cases to substitute (#38826)#40915
expression, cmd: fix ColumnSubstitute and allow some cases to substitute (#38826)#40915ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This pull request is closed because its related version has closed automatic cherry-picking. https://prow.tidb.net/command-help#cherrypick |
This is an automated cherry-pick of #38826
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #38736 and close #40536
Problem Summary:
Take the case from #38736,
the first argument's collation in the like function is utf8mb4_bin, and the second is binary.
So we can't substitute the first argument(utf8mb4_bin to utf8mb4_bin) since it is weakened than binary.
If the collation and coercibility don't change, it's safe to substitute.
What is changed and how it works?
If the collation and coercibility don't change, it's safe to substitute.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.