Skip to content

lightning/parser: support STARTING BY and IGNORE n LINES#40801

Closed
lance6716 wants to merge 5 commits intopingcap:masterfrom
lance6716:add-starting-by
Closed

lightning/parser: support STARTING BY and IGNORE n LINES#40801
lance6716 wants to merge 5 commits intopingcap:masterfrom
lance6716:add-starting-by

Conversation

@lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jan 28, 2023

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

What is changed and how it works?

  • STARTING BY: add token. When meet it reset the state of parser
  • IGNORE n LINES: skip output for n times readRecords

Hide these configuration for lightning, only prepare for future LOAD DATA integration

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
lightning/parser: support STARTING BY and IGNORE LINES
58fdb7b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 28, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 28, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Jan 28, 2023

/cc @gozssky @lichunzhu @GMHDBJD @kennytm

@lance6716
fix CI
78aa356 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
rename
7a6ddc2 
Signed-off-by: lance6716 <lance6716@gmail.com>
@sleepymole
Copy link
Contributor

sleepymole commented Jan 28, 2023

@lance6716 Could you explain why we need these two configurations? Is it possible to do them outside the parser?

@lance6716
Copy link
Contributor Author

lance6716 commented Jan 28, 2023

@lance6716 Could you explain why we need these two configurations? Is it possible to do them outside the parser?

I can't come up with a simple change outside parser. We need use parser to know where a line ends, and these two configurations can skip errors when find line endings.

I have added some unit tests, when the skipped content contains special characters like fields delimiter it's very complex.

@lance6716
fix build
02c7bbd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title lightning/parser: support STARTING BY and IGNORE n LINES WIP lightning/parser: support STARTING BY and IGNORE n LINES Jan 28, 2023
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2023
@lance6716
add some test
348ea76 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title WIP lightning/parser: support STARTING BY and IGNORE n LINES lightning/parser: support STARTING BY and IGNORE n LINES Jan 29, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Jan 29, 2023

/hold

IGNORE n LINES should be able to move out of parser, let caller call ReadUntilTerminator for n times. And I'll check if put more restriction on STARTING BY could simplify the code

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Jan 29, 2023

should be replaced by #40821

@lance6716 lance6716 mentioned this pull request Jan 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@sleepymole sleepymole Awaiting requested review from sleepymole

@kennytm kennytm Awaiting requested review from kennytm

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lance6716 @ti-chi-bot @sleepymole