lightning: check hasDupe and tableID when resolve duplicate rows (#40696)#40793
Merged
ti-chi-bot merged 4 commits intopingcap:release-6.5from Feb 19, 2023
Merged
Conversation
12 tasks
Member
Author
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
sleepymole
approved these changes
Jan 28, 2023
dsdashun
approved these changes
Jan 31, 2023
Contributor
|
/hold |
Contributor
|
This cherry-pick must be merged with #41488. |
Contributor
|
/unhold |
Contributor
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: b2aa489223a55e6a139db27640030fc9cb1a741e |
Contributor
|
/retest |
b2aa489 to
a94398a
Compare
Contributor
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: a94398a |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #40696
What problem does this PR solve?
Issue Number: close #40657
Problem Summary:
ResolveDuplicateRowsmay accidentally delete imported data even if there is no duplicate data is detected. See #40657 (comment).What is changed and how it works?
Add two checks when deleting duplicate data:
ResolveDuplicateRowswhen no duplicate data is detected.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.