Skip to content

json, expression: add json unary not implementation (#40723)#40726

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-40723-to-release-6.1
Closed

json, expression: add json unary not implementation (#40723)#40726
ti-chi-bot wants to merge 1 commit intopingcap:release-6.1from
ti-chi-bot:cherry-pick-40723-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40723

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #40683

Problem Summary:

Implement a new json unary not. Currently it's implemented through casting to double and run unary not on the double. However, the compatible implementation should be comparing the json with zero json.

Related TiKV implementation: tikv/tikv#14070

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that unary not json is not compatible with MySQL

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. do-not-merge/cherry-pick-not-approved labels Jan 19, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 43493b5 link true /test check-dev
idc-jenkins-ci-tidb/build 43493b5 link true /test build
idc-jenkins-ci-tidb/unit-test 43493b5 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 43493b5 link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test 43493b5 link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YangKeao
Copy link
Member

Oops. I realized that 6.1 JSON hasn't GA, just close it.

@YangKeao YangKeao closed this Jan 19, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40723-to-release-6.1 branch April 15, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants