Skip to content

BR: add lock with ttl for checkpoint backup (#40563)#40685

Merged
ti-chi-bot merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40563-to-release-6.5
Jan 18, 2023
Merged

BR: add lock with ttl for checkpoint backup (#40563)#40685
ti-chi-bot merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40563-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 18, 2023

This is an automated cherry-pick of #40563

What problem does this PR solve?

Issue Number: close #40561

Problem Summary:
Add a lock with ttl for checkpoint backup, in order to prevent the same task from being run on different BRs at the same time.

What is changed and how it works?

  1. flush a lock file with ttl to the external storage regularly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#40563
ed24408 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 18, 2023
@Leavrth
fix the conflicts
4be848c 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 18, 2023
@fengou1 fengou1 self-requested a review January 18, 2023 08:03
@Leavrth
Copy link
Contributor

Leavrth commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023

@Leavrth: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2023
@Leavrth
Copy link
Contributor

Leavrth commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4be848c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c1bb1fa into pingcap:release-6.5 Jan 18, 2023
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 13, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40563-to-release-6.5 branch April 15, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

+1 more reviewer

@fengou1 fengou1 fengou1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Leavrth Leavrth

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @Leavrth @3pointer @fengou1 @VelocityLight