Skip to content

import: check table empty skips using index (#39604)#40667

Merged
ti-chi-bot merged 3 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39604-to-release-6.1
Jan 18, 2023
Merged

import: check table empty skips using index (#39604)#40667
ti-chi-bot merged 3 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39604-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 17, 2023

This is an automated cherry-pick of #39604

What problem does this PR solve?

Issue Number: close #39477

Problem Summary:

What is changed and how it works?

  • When pre-checking whether target table is empty, skip using the index and directly scan the record.
  • Added integration tests to verify that.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@dsdashun @ti-chi-bot
This is an automated cherry-pick of pingcap#39604
156ef1a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dsdashun
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jan 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jan 17, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 17, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2023
@dsdashun
Copy link
Contributor

dsdashun commented Jan 17, 2023

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2023
@dsdashun
Copy link
Contributor

dsdashun commented Jan 18, 2023

/cc @lance6716 @D3Hunter

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2023
@dsdashun
Copy link
Contributor

dsdashun commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 830b34c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@ti-chi-bot ti-chi-bot merged commit 77cea7a into pingcap:release-6.1 Jan 18, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39604-to-release-6.1 branch April 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

+1 more reviewer

@dsdashun dsdashun dsdashun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsdashun dsdashun

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @dsdashun @lance6716 @VelocityLight