Skip to content

*: Reorganize partition: tiflash and update table | tidb-test=pr/2069#40635

Closed
mjonss wants to merge 941 commits intopingcap:feature/reorganize-partitionfrom
mjonss:reorg-part-tiflash-and-update-table
Closed

*: Reorganize partition: tiflash and update table | tidb-test=pr/2069#40635
mjonss wants to merge 941 commits intopingcap:feature/reorganize-partitionfrom
mjonss:reorg-part-tiflash-and-update-table

Conversation

@mjonss
Copy link
Contributor

@mjonss mjonss commented Jan 16, 2023

What problem does this PR solve?

Issue Number: ref #38535

Problem Summary:

What is changed and how it works?

PR on top of #40543 so looks bigger than it is.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

mjonss and others added 30 commits December 20, 2022 16:44
@mjonss
*: Fix issue 39999, used wrong column id list for checking partitions (…
4a72171 
…pingcap#40003)

close pingcap#39999
@hawkingrei
oomtest: add whitelist for oom test to fix flaky test (pingcap#40055)
6ab3803 
close pingcap#40054
@time-and-fate
*: extend skyline pruning diagnostic info and add extra warnings (pin…
017901d 
…gcap#39894)

ref pingcap#39893
@crazycs520
ddl: add privilege check when alter table add foreign key (pingcap#40051
0f3031e 
)

close pingcap#40050
@qw4990
planner: add more test cases for non-prep plan cache (pingcap#40060)
5f1a739
@chrysan
sessionctx: disable gc aware memory track (pingcap#40019)
806fcbf 
close pingcap#39971
@chrysan
*: make auto-analyze killable by global memory limit (pingcap#39978)
fdf335e 
ref pingcap#39971, close pingcap#39994
@mjonss
Linting
5a60f7e
@mjonss
Updated after make bazel_prepare
85257f3
@hawkingrei
cpu: fix ticker to avoid close early (pingcap#40036)
ae2d551 
ref pingcap#40029
@dependabot
build(deps): bump golang.org/x/time from 0.2.0 to 0.3.0 (pingcap#39912)
a2fa187
@tangenta
ddl: use latest ts to read record for adding index (pingcap#40081)
51cce45 
close pingcap#40074
@hawkingrei
executor: close recordset again (pingcap#40073)
2150c6b
@Reminiscent
planner: add more test cases for MPP hints (pingcap#39933)
785f515
@fzzf678
planner: support set binding status by sql digest (pingcap#39517)
08f23ef 
ref pingcap#39199
@xiongjiwei
ddl: check the limitation when creating multi-valued index (pingcap#3…
b4f500e 
…9818)

close pingcap#40086
@CbcWestwolf
sysvar: allow modifying 'tidb_allow_remove_auto_inc' when SEM is ON (p…
13e2120 
…ingcap#40083)

close pingcap#38238
@crazycs520
*: fix issue of multi-schema change with foreign key (pingcap#40042)
ad0c202 
close pingcap#40037
@qw4990
planner: check the ignore-plan-cache hint in insert-stmt (pingcap#4…
9e8a21c 
…0080)

ref pingcap#39717, close pingcap#40079
@Reminiscent
parser: support keep_order and no_keep_order hint (pingcap#39965)
fc3f04b 
ref pingcap#39964
@xiongjiwei
*: filter particularly errors when truncateAsWarning is true (pingc…
47ace08 
…ap#40078)
@mjonss
Removed CI debug log
273e7e8
@mjonss
Cleaned PR to only have the core of the data copying parts
b086421
@mjonss
Merge branch 'reorg-part-data-reorg' into reorg-part-rollback
74fa4c4
@mjonss
More cleanup of PR to only focus on reorg data copy
b0c16cd
@mjonss
Merge branch 'reorg-part-data-reorg' into reorg-part-rollback
73dcf5a
@mjonss
Added check to avoid null-pointer dereferencing
0accdd8
@mjonss
Fixed nil session context
8c914b0
@mjonss
Cleanup
0678894
@mjonss
Added Info logs for debugging in CI
3a1adcd
@mjonss mjonss requested a review from a team as a code owner January 16, 2023 23:45
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2023
@mjonss mjonss mentioned this pull request Jan 16, 2023
Closed
13 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
@mjonss mjonss changed the base branch from master to feature/reorganize-partition January 18, 2023 00:31
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2023
@mjonss mjonss mentioned this pull request Jan 18, 2023
Closed
12 tasks
@mjonss mjonss changed the title *: Reorganize partition: tiflash and update table *: Reorganize partition: tiflash and update table | tidb-test=pr/2069 Jan 18, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Jan 18, 2023

/test mysql-test

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2023

@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 1af113a link true /test check-dev
idc-jenkins-ci-tidb/unit-test 1af113a link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mjonss
Copy link
Contributor Author

mjonss commented Jan 18, 2023

Splitted into #40714 and #40715.

@mjonss mjonss closed this Jan 18, 2023
@mjonss mjonss deleted the reorg-part-tiflash-and-update-table branch January 23, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.