Skip to content

ttl: fix the TTL job reports error when primary key contains a column with type ENUM (#40457)#40485

Merged
ti-chi-bot merged 6 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40457-to-release-6.5
Feb 8, 2023
Merged

ttl: fix the TTL job reports error when primary key contains a column with type ENUM (#40457)#40485
ti-chi-bot merged 6 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40457-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 11, 2023

This is an automated cherry-pick of #40457

What problem does this PR solve?

Issue Number: close #40456

Because ttl method FormatSQLDatum cannot format the value with column type ENUM or SET, the delete task will report error when running. This PR fixed it.

What is changed and how it works?

Support type ENUM and SET for FormatSQLDatum

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

ttl: fix the TTL job reports error when primary key contains a column with type `ENUM`

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Jan 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 11, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 7, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
YangKeao
YangKeao approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2023
@lcwangchao
Copy link
Collaborator

lcwangchao commented Feb 7, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 7, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3c4dc32

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023
@lcwangchao
Copy link
Collaborator

lcwangchao commented Feb 7, 2023

/retest

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 7, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator

lcwangchao commented Feb 8, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit b0550b4 into pingcap:release-6.5 Feb 8, 2023
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 13, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40457-to-release-6.5 branch April 15, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

@lcwangchao lcwangchao

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @lcwangchao @YangKeao @VelocityLight